-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Resizable: Fix resizing of elems with box-sizing: border-box
#2012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We had broken CI for a while. Please rebase to the latest We'll also need unit tests for the change and I'll need some time to understand what's exactly going on here; although, if you could add comments on GitHub explaining the code changes, that'd speed things up. |
If you're interested in finishing this, there are some existing |
I'll try my best... This will be my first encounter with a unit test so any help from anyone it would be very much appreciated |
It's best to look at existing tests and do something similar. Of course, feel free to ask questions. |
@mgol just added a test. I hope it's ok! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments. Please also merge the latest main
to your branch. When that gets addressed, I'll approve the PR.
@fnagel do you have any other concerns or are you also OK with landing this after my remarks are addressed?
Co-authored-by: Michał Gołębiowski-Owczarek <[email protected]>
Co-authored-by: Michał Gołębiowski-Owczarek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good to me now. I'll still wait a bit for @fnagel's review before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 by reading
box-sizing: border-box
Landed, thanks! |
fixes #1979